9os

commit 04d668e48707dca46cda434946ce00dfda5468bc
parent ebf23c399468f70c8a7e3f4276166ef49a033ea4
Author: Dimitris Papastamos <dimitris.papastamos@arm.com>
Date:   Thu,  8 Nov 2018 11:15:51 +0000

[debuglang] No need to specify base for get

Specifying a base is not particularly needed.  Most debuggers default
to hex and people don't usually need more than that.

Fix a segfault while at it.

Change-Id: I83e0f8da089b811c972b8d5357e9f7f576c06b02
Signed-off-by: Dimitris Papastamos <dimitris.papastamos@arm.com>

Diffstat:
M
src/debuglang/debuglang.c
 | 
26
++++----------------------

1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/src/debuglang/debuglang.c b/src/debuglang/debuglang.c
@@ -165,33 +165,15 @@ static int
 do_get(struct args *args)
 {
 	unsigned long long *reg = NULL;
-	char *fmt;
+
+	if (args->argc != 2)
+		error("usage: get <reg>");
 
 	reg = get_named_reg(args->argv[1]);
 	if (reg == NULL)
 		error("Register '%s' not found", args->argv[1]);
 
-	switch (args->argc) {
-	case 3:
-		switch (estrtoull(args->argv[2], 10)) {
-		case 10:
-			fmt="%llu\n";
-			break;
-		case 16:
-			fmt="%llx\n";
-			break;
-		default:
-			error("Unsupported base for read:%s\nsupported: 10,16",
-			      args->argv[2]);
-		}
-		break;
-	case 2:
-		fmt="%llu\n";
-		break;
-	default:
-		error("Invalid number of arguments for read");
-	}
-	printf(fmt, *reg);
+	printf("%llx\n", *reg);
 	return 0;
 }