scc

commit 7ce5769695cbcd21227a937a5f60d80a1a464d1b
parent f761999f59431d41339a2d8978faa43f53aa930e
Author: Roberto E. Vargas Caballero <k0ga@shike2.com>
Date:   Thu, 15 May 2014 12:04:00 +0200

Forbid declaration of incomplete type variables

Diffstat:
M
cc1/decl.c
 | 
2
++
M
cc1/types.c
 | 
16
+++++++++-------

2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/cc1/decl.c b/cc1/decl.c
@@ -156,6 +156,8 @@ declarator(Type *tp, int8_t flags)
 			break;
 		}
 	}
+	if (!tp->defined)
+		error("declared variable '%s' of incomplete type", sym->name);
 	if (!sym)
 		sym = &dummy;
 	sym->type = tp;
diff --git a/cc1/types.c b/cc1/types.c
@@ -144,7 +144,7 @@ Type *
 mktype(Type *tp, uint8_t op, uint16_t nelem)
 {
 	static Type *typetab[NR_TYPE_HASH], **tbl;
-	static uint8_t t;
+	static uint8_t t, def;
 	register Type *bp;
 	char letter;
 
@@ -163,18 +163,20 @@ mktype(Type *tp, uint8_t op, uint16_t nelem)
 	}
 
 	switch (op) {
-	case PTR:    letter = L_POINTER; break;
-	case FTN:    letter = L_FUNCTION; break;
-	case ARY:    letter = L_ARRAY; break;
-	case ENUM:   letter = L_INT; break;
-	case STRUCT: letter = L_STRUCT; break;
-	default: letter = tp->letter;
+	case PTR:    letter = L_POINTER,  def = 1; break;
+	case FTN:    letter = L_FUNCTION, def = 1; break;
+	case ARY:    letter = L_ARRAY,    def = nelem != 0; break;
+	case ENUM:   letter = L_INT,      def = 0; break;
+	case STRUCT: letter = L_STRUCT,   def = 0; break;
+	/* TODO case UNION: */
+	default: letter = tp->letter; /* is it possible? */
 	}
 	bp = xcalloc(1, sizeof(*bp));
 	bp->next = *tbl;
 	bp->type = tp;
 	bp->op = op;
 	bp->letter = letter;
+	bp->defined = def;
 	return *tbl = bp;
 }