commit 67dc80bf14ef15162fa94ded320c7a338a330267
parent 89dd30dc93dcee2a470c322901a63dd69f476a7c
Author: Roberto E. Vargas Caballero <k0ga@shike2.net>
Date: Fri, 1 May 2026 21:45:02 +0200
libc/qsort: Use unsigned char instead of char
While it is not very important in this specific case
because we only transfer between char pointers, but
having char can involve sign extensions that are
later discarded, so it is just better to use
unsigned.
Diffstat:
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/libc/stdlib/qsort.c b/src/libc/stdlib/qsort.c
@@ -14,7 +14,7 @@ struct qsort {
};
static void
-swap(char *i, char *j, size_t n)
+swap(unsigned char *i, unsigned char *j, size_t n)
{
do {
char c = *i;
@@ -29,10 +29,10 @@ swap(char *i, char *j, size_t n)
* array.
*/
static void
-xqsort(char *a, size_t n, struct qsort *qs)
+xqsort(unsigned char *a, size_t n, struct qsort *qs)
{
size_t nj, ni, es = qs->es;
- char *pi, *pj, *pn;
+ unsigned char *pi, *pj, *pn;
if (n <= 1)
return;